Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 9.1.1 on May 17, 2022 #6304

Closed
19 tasks done
hugovk opened this issue May 17, 2022 · 11 comments
Closed
19 tasks done

Release 9.1.1 on May 17, 2022 #6304

hugovk opened this issue May 17, 2022 · 11 comments
Labels

Comments

@hugovk
Copy link
Member

hugovk commented May 17, 2022

Point Release

Released as needed for security, installation or critical bug fixes.

  • Make necessary changes in main branch.
  • Update CHANGES.rst.
  • Check out release branch e.g.:
    git checkout -t remotes/origin/5.2.x
  • Cherry pick individual commits from main branch to release branch e.g. 5.2.x, then git push.
  • Check GitHub Actions and AppVeyor to confirm passing tests in release branch e.g. 5.2.x.
  • In compliance with PEP 440, update version identifier in src/PIL/_version.py
  • Run pre-release check via make release-test.
  • Create tag for release e.g.:
    git tag 5.2.1
    git push
    git push --tags
  • Create and check source distribution:
    make sdist
    python3 -m twine check --strict dist/*
  • Create binary distributions

Binary Distributions

Windows

Mac and Linux


  • Check and upload all binaries and source distributions e.g.:
    python3 -m twine check --strict dist/*
    python3 -m twine upload dist/Pillow-5.2.1*
  • Publish the release on GitHub

Publicize Release

Documentation

Docker Images

  • Update Pillow in the Docker Images repository
    git clone https://github.com/python-pillow/docker-images
    cd docker-images
    ./update-pillow-tag.sh [[release tag]]
@hugovk hugovk added the Release label May 17, 2022
@hugovk
Copy link
Member Author

hugovk commented May 17, 2022

Hi @cgohlke, please could we have Windows binaries for 9.1.1?

@cgohlke
Copy link
Contributor

cgohlke commented May 17, 2022

Here you go. You may not want to upload the wheels for Python 3.11b1 to PyPI.

@hugovk
Copy link
Member Author

hugovk commented May 17, 2022

@cgohlke Thank you! Yep, I skipped the 3.11 beta ones. Nice to see they're building though :)

For 3.10 last year, we were going to do our October release as soon as 3.10 was released, but then decided to put out 3.10 wheels already during the RC period to help people test: #5569 (comment). So I expect we'll do something similar this year.

3.11 schedule:

  • 3.11.0 beta 2: Monday, 2022-05-30
  • 3.11.0 beta 3: Thursday, 2022-06-16
  • 3.11.0 beta 4: Saturday, 2022-07-09
  • 3.11.0 candidate 1: Monday, 2022-08-01
  • 3.11.0 candidate 2: Monday, 2022-09-05
  • 3.11.0 final: Monday, 2022-10-03

(Maybe even include a 3.11 in the July release? Anyway, we can discuss this stuff later.)


🚀 Pillow 9.1.1 is released!

@ulgens
Copy link

ulgens commented May 17, 2022

Installing 9.1.1 under python:3.10.4-slim-bullseye (M1 cpu) fails with the error below but 9.1.0 works fine. I'm not sure if this is something that went wrong with the release or a bug in the code.

#11 17.34         running build_ext
#11 17.34
#11 17.34
#11 17.34         The headers or library files could not be found for zlib,
#11 17.34         a required dependency when compiling Pillow from source.
#11 17.34
#11 17.34         Please see the install instructions at:
#11 17.34            https://pillow.readthedocs.io/en/latest/installation.html
#11 17.34
#11 17.34         Traceback (most recent call last):
#11 17.34           File "/tmp/pip-req-build-e8_ay6ey/setup.py", line 989, in <module>
#11 17.34             setup(
#11 17.34           File "/usr/local/lib/python3.10/site-packages/setuptools/__init__.py", line 153, in setup
#11 17.34             return distutils.core.setup(**attrs)
#11 17.34           File "/usr/local/lib/python3.10/distutils/core.py", line 148, in setup
#11 17.34             dist.run_commands()
#11 17.34           File "/usr/local/lib/python3.10/distutils/dist.py", line 966, in run_commands
#11 17.34             self.run_command(cmd)
#11 17.34           File "/usr/local/lib/python3.10/distutils/dist.py", line 985, in run_command
#11 17.34             cmd_obj.run()
#11 17.34           File "/usr/local/lib/python3.10/site-packages/setuptools/command/install.py", line 61, in run
#11 17.34             return orig.install.run(self)
#11 17.34           File "/usr/local/lib/python3.10/distutils/command/install.py", line 568, in run
#11 17.34             self.run_command('build')
#11 17.34           File "/usr/local/lib/python3.10/distutils/cmd.py", line 313, in run_command
#11 17.34             self.distribution.run_command(command)
#11 17.34           File "/usr/local/lib/python3.10/distutils/dist.py", line 985, in run_command
#11 17.34             cmd_obj.run()
#11 17.34           File "/usr/local/lib/python3.10/distutils/command/build.py", line 135, in run
#11 17.34             self.run_command(cmd_name)
#11 17.34           File "/usr/local/lib/python3.10/distutils/cmd.py", line 313, in run_command
#11 17.34             self.distribution.run_command(command)
#11 17.34           File "/usr/local/lib/python3.10/distutils/dist.py", line 985, in run_command
#11 17.34             cmd_obj.run()
#11 17.34           File "/usr/local/lib/python3.10/site-packages/setuptools/command/build_ext.py", line 79, in run
#11 17.34             _build_ext.run(self)
#11 17.34           File "/usr/local/lib/python3.10/distutils/command/build_ext.py", line 340, in run
#11 17.34             self.build_extensions()
#11 17.34           File "/tmp/pip-req-build-e8_ay6ey/setup.py", line 804, in build_extensions
#11 17.34             raise RequiredDependencyException(f)
#11 17.34         __main__.RequiredDependencyException: zlib

@hugovk
Copy link
Member Author

hugovk commented May 17, 2022

It's trying a source build there.

If you install 9.1.0 with no cache, does it install a wheel?

For example, what output do you get with this?

python3 -m pip install --no-cache-dir pillow==9.1.0

@ulgens
Copy link

ulgens commented May 17, 2022

@hugovk

root@9a43f098af83:/code/src# python3 -m pip install --no-cache-dir pillow==9.1.0
Collecting pillow==9.1.0
  Downloading Pillow-9.1.0-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (4.3 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.3/4.3 MB 11.9 MB/s eta 0:00:00
Installing collected packages: pillow
Successfully installed pillow-9.1.0

vs

root@9a43f098af83:/code/src# python3 -m pip install --no-cache-dir pillow==9.1.1
Collecting pillow==9.1.1
  Downloading Pillow-9.1.1.tar.gz (49.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 49.8/49.8 MB 23.5 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: pillow
  Building wheel for pillow (setup.py) ... error

@hugovk
Copy link
Member Author

hugovk commented May 17, 2022

Thanks, we're missing the aarch64 wheels, the others are built on GitHub Actions but these are built by Travis CI and for some reason didn't upload to GitHub Releases (and from there to PyPI):

https://app.travis-ci.com/github/python-pillow/pillow-wheels/builds/250747395

We'll look into it.

@hugovk hugovk pinned this issue May 17, 2022
@hugovk
Copy link
Member Author

hugovk commented May 17, 2022

@ulgens Now uploaded to PyPI:

Pillow-9.1.1-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
Pillow-9.1.1-cp37-cp37m-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
Pillow-9.1.1-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
Pillow-9.1.1-cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl

Please could you try again?

@ulgens
Copy link

ulgens commented May 17, 2022

@hugovk

root@83a465c7191e:/code/src# python3 -m pip install --no-cache-dir pillow==9.1.1
Collecting pillow==9.1.1
  Downloading Pillow-9.1.1-cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (3.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 3.0/3.0 MB 10.7 MB/s eta 0:00:00
Installing collected packages: pillow
  Attempting uninstall: pillow
    Found existing installation: Pillow 9.1.0
    Uninstalling Pillow-9.1.0:
      Successfully uninstalled Pillow-9.1.0
Successfully installed pillow-9.1.1

Seems okay now. Thanks a lot.

@aclark4life
Copy link
Member

Thanks all! Pinned Tweet is up.

Screenshot 2022-05-18 104151

@hugovk
Copy link
Member Author

hugovk commented May 18, 2022

Issue python-pillow/pillow-wheels#295 and PR python-pillow/pillow-wheels#296 to help release aarch64 wheels for next time.

@radarhere radarhere unpinned this issue May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants