Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed calling DisplayViewer or XVViewer without a title #6136

Merged
merged 1 commit into from Mar 24, 2022

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Mar 15, 2022

Requested in 8da8013#r68650261
Resolves #6146

That comment points out that

def show(image, title=None, **options):
r"""
Display a given image.
:param image: An image object.
:param title: Optional title. Not all viewers can display the title.
:param \**options: Additional viewer options.
:returns: ``True`` if a suitable viewer was found, ``False`` otherwise.
"""
for viewer in _viewers:
if viewer.show(image, title=title, **options):
can set title to None, which is then passed (through Viewer.show and show_image) to DisplayViewer and XVViewer as None for one of the values passed to subprocess.Popen.

This problem was introduced in #6010.

@radarhere radarhere added the Bug Any unexpected behavior, until confirmed feature. label Mar 15, 2022
@radarhere radarhere changed the title Do not pass None to subprocess Fixed calling DisplayViewer or XVViewer without a title Mar 15, 2022
@hugovk hugovk merged commit 3ce6501 into python-pillow:main Mar 24, 2022
@radarhere radarhere deleted the imageshow branch March 24, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Any unexpected behavior, until confirmed feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImageShow.show() for DisplayViewer doesn't work if no title is given
2 participants