Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a (0, 0) image,
im.load()
currently returnsNone
.This is because
load()
tests ifself.im
is truthy.Pillow/src/PIL/Image.py
Lines 867 to 876 in 92c26a7
And the image size is what is used to determine the boolean value.
So this PR instead changes the Python code to check
self.im is not None
, there and in other locations. I've added a check toassert im.load() is not None
for a (0, 0) image.This then required existing checks in Tests/test_image_access.py on (0, 0) images to be updated. Why? Because once the (0, 0) image started returning an access object from
load()
, it is revealed that PixelAccess and PyAccess return different errors when the index is out of range.Pillow/src/_imaging.c
Line 449 in 92c26a7
Pillow/src/PIL/PyAccess.py
Line 126 in 92c26a7