Added support for reading BMP images with RLE8 compression #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
bmp_rle8
branch
4 times, most recently
from
4198c5c
to
755c1a0
Compare
radarhere
commented
Mar 4, 2022
| @@ -40,6 +40,7 @@ def test_questionable(): | |||
| "rgb32fakealpha.bmp", | |||
| "rgb24largepal.bmp", | |||
| "pal8os2sp.bmp", | |||
| "pal8rletrns.bmp", | |||
There was a problem hiding this comment.
When running this locally, I was told to add this by the test.
Pillow/Tests/test_bmp_reference.py
Line 50 in 38f4660
radarhere
force-pushed
the
bmp_rle8
branch
3 times, most recently
from
55c0715
to
72beef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3425
See https://docs.microsoft.com/en-us/windows/win32/gdi/bitmap-compression for documentation.
While my initial commit fixes test1.bmp from the issue, it doesn't fix test3.bmp. Investigating, I found that there were rows with too much data present. So I've added another commit to trim that out.