Ensure cleanup() is called for PyEncoders #6096
Merged
+30
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ImageFile, the encoder
cleanup()
method is not called from Python if there is an error.Pillow/src/PIL/ImageFile.py
Lines 505 to 520 in 2f2b48d
However,
cleanup()
would still be called from_dealloc
in C.Pillow/src/encode.c
Lines 94 to 98 in 2f2b48d
Except that doesn't help a PyEncoder. So this PR ensures
cleanup()
is called from ImageFile.