Changed quantize default dither to FLOYDSTEINBERG #6068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pillow.readthedocs.io/en/stable/reference/Image.html#PIL.Image.Image.quantize
It's weird that the documentation specified twice what the default was, but I guess that the FLOYDSTEINBERG constant has a raw value of 1. Oh wait, no, it doesn't.
Pillow/src/PIL/Image.py
Lines 168 to 172 in 29b7030
If you search for 'dither' in Image.py, _imaging.c and Convert.c, it makes no difference in the code whether it is 1 or 3.
So this PR suggests changing the
quantize()
default dither toFLOYDSTEINBERG
. It should have no effect on the behaviour of Pillow, but it will stop the docstring from being confusing.While I'm here, I also stop passing
dither
to the C functiontobilevel
, since it is unused.