Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimagequant included in conda-forge package #6019

Closed
FelixS90 opened this issue Feb 4, 2022 · 3 comments
Closed

libimagequant included in conda-forge package #6019

FelixS90 opened this issue Feb 4, 2022 · 3 comments
Labels
Anaconda Issues with Anaconda's Pillow

Comments

@FelixS90
Copy link

FelixS90 commented Feb 4, 2022

What did you do?

conda install -c conda-forge pillow

What did you expect to happen?

Not pulling in libimagequant as a dependency as outlined in https://pillow.readthedocs.io/en/stable/installation.html#external-libraries ("Libimagequant is licensed GPLv3, which is more restrictive than the Pillow license, therefore we will not be distributing binaries with libimagequant support enabled.")

What actually happened?

libimagequant was pulled in as a dependency.

What are your OS, Python and Pillow versions?

  • OS: Win10
  • Python: 3.9
  • Pillow: 9.0

Note: The behaviour seems to have changed from 8.* to 9.* (from looking at the meta.yaml downloaded through the wheels from https://anaconda.org/conda-forge/pillow/files?sort=basename&sort_order=desc).
image

Note: I have not confirmed with PyPI.

Feel free to delegate to the people from conda-forge if you think that this is a repackaging issue.

@radarhere
Copy link
Member

meta.yaml would be controlled from https://github.com/conda-forge/pillow-feedstock, so this isn't directly a question for this repository, no. The line you're referring to was added in conda-forge/pillow-feedstock#104

That said, in my limited understanding, I wouldn't have thought that meta.yml is putting libimagequant into a file with Pillow and sending it out. I think it's just listing it as something that is separately installed.

@h-vetinari
Copy link

Hey, one of the conda-forge maintainers here.

Which platform are you on? conda-forge/pillow-feedstock#107 removed libimagequant on windows due to other issues.

Also, it seems you're in an environment that doesn't allow GPL dependencies, is that correct? We could solve this (in theory) by having different outputs for different bindings, but considering the number of them, that's would be a bit of a hassle...

@radarhere
Copy link
Member

@FelixS90 did you have anything further to add? This matter seems to have now been picked up in conda-forge/pillow-feedstock#111 and conda-forge/pillow-feedstock#109

@aclark4life aclark4life added the Anaconda Issues with Anaconda's Pillow label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Anaconda Issues with Anaconda's Pillow
Projects
None yet
Development

No branches or pull requests

4 participants