libwebp 1.2.2 fixed endian bugs #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3927
Resolves #4213
While investigating
TestFileWebpAnimation.test_write_animation_LandTestFileWebpAnimation.test_write_animation_RGBfailures on big-endian, I came to the conclusion that it was not a problem in our code, but in libwebp itself. I reported this to them, it was accepted, and then fixed in libwebp 1.2.2.This PR removes the xfails on those tests for big endian, runs the first half of them that passes before libwebp 1.2.2, and then skips the second half if libwebp 1.2.2 or greater is not available.
python-pillow/docker-images#128 and #5982 made libwebp 1.2.2 available to the CI job.