When saving RGBA to GIF, make use of first transparent palette entry #5859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
radarhere
changed the title
radarhere
force-pushed
the
saving_rgba_gif
branch
from
59b08e4
to
0e10a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4640
When saving an image as a GIF, the image passes through
_normalize_mode, to convert the image to 1, L or P.When saving a single RGBA image as a GIF, the transparency is currently lost. This PR fixes that by setting the "transparency" key in the
infodictionary to the first transparent palette entry (if you think that might not be very effective, since there could be many different transparent palette entries, remember #5282).