Added rounding when converting P and PA #5824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5728
The issue discusses a pixel in an image with the palette value
(177, 175, 175)
, and asks why converting from P to L doesn't convert it to 176. That conversion uses the L macro -Pillow/src/libImaging/Convert.c
Lines 1012 to 1016 in a3d1e2f
Pillow/src/libImaging/Convert.c
Line 43 in a3d1e2f
Applying the L macro,
(177*299 + 175*587 + 175*114) / 1000
= 175.598Except the
p2l
code above rounds it down. This PR applies proper rounding to bring it to 176.