Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use bitmap glyphs when drawing text with stroker #5761

Merged
merged 1 commit into from Oct 14, 2021

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Oct 14, 2021

Fixes #5759

@hugovk
Copy link
Member

hugovk commented Oct 14, 2021

Is the CIFuzz failure unrelated?

@nulano
Copy link
Contributor Author

nulano commented Oct 14, 2021

Is the CIFuzz failure unrelated?

The log is not showing up for me right now (the start mentions Tiff, the rest is blank), but it is highly unlikely to be related - the flag added by this PR just tells FreeType to ignore a part of the font (embedded bitmaps). I'm not even sure if CIFuzz has any test cases drawing text with stroke_width.

@radarhere
Copy link
Member

radarhere commented Oct 14, 2021

I can confirm that the CIFuzz failure is unrelated. A branch from master with a simple change is currently failing - https://github.com/radarhere/Pillow/actions/runs/1341480212

@hugovk
Copy link
Member

hugovk commented Oct 14, 2021

Thanks!

@hugovk hugovk merged commit 1b5e662 into python-pillow:master Oct 14, 2021
@nulano nulano deleted the stroke branch October 14, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSError: invalid argument when draw stroke with specific font
3 participants