Update winbuild libimagequant to 2.16.0 #5727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Sep 21, 2021
| "url": "https://github.com/ImageOptim/libimagequant/archive/16adaded22d1f90db5c9154a06d00a8b672ca09a.zip", # noqa: E501 | ||
| "filename": "libimagequant-16adaded22d1f90db5c9154a06d00a8b672ca09a.zip", | ||
| "dir": "libimagequant-16adaded22d1f90db5c9154a06d00a8b672ca09a", | ||
| # commit: Merge branch 'master' into msvc (matches 2.16.0 tag) |
There was a problem hiding this comment.
If we're using a tag, can we download the actual tag archive instead of a commit hash?
From https://github.com/ImageOptim/libimagequant/releases/tag/2.16.0:
https://github.com/ImageOptim/libimagequant/archive/refs/tags/2.16.0.zip
There was a problem hiding this comment.
This is a commit merging the 2.16.0 tag into the msvc branch, there are a few minor changes still: ImageOptim/libimagequant@2.16.0...f41ee30
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit is up to date with the latest tag, with minor changes needed for MSVC: ImageOptim/libimagequant@f41ee30...2.16.0
The patches need to be updated to fix an issue with the provided CMakeLists.txt.