Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Split MINGW to own workflow, remove redundant job #5709

Merged
merged 3 commits into from Sep 12, 2021
Merged

CI: Split MINGW to own workflow, remove redundant job #5709

merged 3 commits into from Sep 12, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 11, 2021

A couple of minor improvements spotted during last release cycle.

Changes proposed in this pull request:

  • Split MINGW out from test-windows.yml into its own workflow

    • makes each yml file shorter
    • there's not much overlap/re-use, and it's now easier to diff the files to compare
    • I happened to hit some network timeouts during the release, GHA still only allows re-starting the whole workflow (not a single job), so this allows wasting less time/electricity/resources

  • Remove the final "Valgrind Test Successful" job from test-valgrind.yml

    • redundant: not used by Mergify
    • avoids the CI waiting and running a job for this, however quick
    • workflow reports success sooner

cc @nulano about the MINGW stuff.

@hugovk hugovk added the Testing label Sep 11, 2021
nulano
nulano approved these changes Sep 11, 2021
View reviewed changes
Copy link
Contributor

@nulano nulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, should be fine.

@hugovk @radarhere
Rename to "Build" for consistency
a761d9b 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@hugovk hugovk added the automerge Automatically merge PRs that are ready label Sep 12, 2021
@radarhere radarhere merged commit d7798fb into python-pillow:master Sep 12, 2021
@hugovk hugovk deleted the update-ci branch September 12, 2021 08:32
@radarhere radarhere mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere approved these changes

@nulano nulano nulano approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PRs that are ready Testing Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugovk @radarhere @nulano