Convert to float for comparison with float in IFDRational __eq__ #5412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is up for debate.
Consider this behaviour.
I feel like this is unexpected. Why is this happening? Well,
So despite the fact that
Fraction(7, 5)
is not equal to 1.4.This isn't the case for all values.
This PR 'fixes' this behaviour in
IFDRational
by castingFraction
tofloat
when comparing inIFDRational.__eq__()
.As I said, open for debate.