Add preserve_tone option to autocontrast #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Mar 22, 2021
radarhere
reviewed
Mar 22, 2021
radarhere
reviewed
Mar 22, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Mar 23, 2021
hugovk
reviewed
Mar 23, 2021
radarhere
reviewed
Mar 23, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Mar 25, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
hugovk
approved these changes
Mar 27, 2021
radarhere
reviewed
Mar 28, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Mar 29, 2021
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
|
If I remove the change to preserve tone, the tests still pass. I understand that these tests came from #1246 (comment), but they aren't going to prevent us accidentally undoing this change in the future. I've created elejke#2 to add a test to guard against regression, by checking that |
|
Good idea, thank you @radarhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
As already have been discussed here autocontrast function changes the tone of the image because of the usage of separate histograms for each channel.
@broxeph, @wiredfool
Example:
