Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Image._MODEINFO #5316

Merged
merged 3 commits into from Mar 31, 2021
Merged

Removed Image._MODEINFO #5316

merged 3 commits into from Mar 31, 2021

Conversation

radarhere
Copy link
Member

Pillow/src/PIL/Image.py

Lines 218 to 219 in 1d7cbeb

_MODEINFO = {
# NOTE: this table will be removed in future versions. use

This comment has been present since the PIL fork. This PR finally removes Image._MODEINFO.

hugovk
hugovk approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine to remove this without deprecations, it's internal and the comment's been there for over a decade.

Shall we at least mention it in the release notes? Feel free to merge if you think that's not needed!

@radarhere
Copy link
Member Author

Ok, I've added release notes

@hugovk hugovk merged commit 7785931 into python-pillow:master Mar 31, 2021
@radarhere radarhere deleted the modes branch March 31, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@radarhere @hugovk