Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Tk/Tcl 8.4, to be removed in Pillow 10 (2023-07-01) #5216

Merged
merged 1 commit into from Feb 2, 2021

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Jan 21, 2021

Tk/Tcl 8.4.0 was released Sep 18, 2000
Tk/Tcl 8.5.0 was released Dec 20, 2007
Tk/Tcl 8.4.20, the most recent version of 8.4, was released Jun 1, 2013

Support for Tk/Tcl < 8.4 was removed in #1288

@radarhere radarhere added the Deprecation Feature that will be removed in the future label Jan 21, 2021
@hugovk
Copy link
Member

hugovk commented Feb 1, 2021

Sounds reasonable. Do they have formal EOL dates for Tk/Tcl?

Pillow 10 (2023-01-02) is some time away, I'm wondering what the status of 8.5 will be by then.


https://www.tcl.tk/ says 8.7 is in alpha.

https://www.tcl.tk/software/tcltk/choose.html says 8.6 is latest stable (8.6.0 released Dec 20, 2012), and:

Tcl/Tk 8.6.10 is the currently recommended release.

For 8.4 and earlier:

Downloading Tcl/Tk 8.6.10 or newer is recommended


https://www.freshports.org/x11-toolkits/tk85/ says:

DEPRECATED: Tcl/Tk 8.5 is nearing EOL, please consider porting to Tcl/Tk 8.6

And on 12 Jun 2019:

Deprecate Tcl/Tk 8.5 and dependent ports

Tcl/Tk 8.5 is approaching EOL. It might or might get another patch release with 8.7 is released, but people should have started migrating to 8.6 long ago.

Let's include 8.5 in the deprecation?

@radarhere
Copy link
Member Author

The last release of Tcl/Tk 8.5 was 8.5.19 on February 12, 2016

While I haven't seen formal dates, https://core.tcl-lang.org/tcl/wiki?name=Index states

Tcl 8.5 is at End of Life -- please upgrade to 8.6.*!!!

amazon-2-amd64 is still using Tk 8.5 however - https://github.com/python-pillow/Pillow/runs/1804791690?check_suite_focus=true#step:6:543

@hugovk
Copy link
Member

hugovk commented Feb 2, 2021

Okay, let's keep 8.5, doesn't actually affect code removals right now, unlike with 8.4.

We can add 8.5 at a later date if necessary, we have the whole of 2021 for it to join the Pillow 10 (2023-01-02 edit: 2023-07-01) train.

Thanks!

@hugovk hugovk merged commit 54f12f8 into python-pillow:master Feb 2, 2021
@radarhere radarhere deleted the tk branch February 2, 2021 20:22
@hugovk hugovk changed the title Deprecate Tk/Tcl 8.4, to be removed in Pillow 10 (2023-01-02) Deprecate Tk/Tcl 8.4, to be removed in Pillow 10 (2023-07-01) Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Feature that will be removed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants