Handle PCX images with an odd stride #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5203
The PCX specification states that 'BytesPerLine' 'MUST be an EVEN number.'
The two images that are failing in the issue list the BytesPerLine as 371 and 409. So they are malformed.
This may not be uncommon, since it has been noted in an earlier issue
The images started to fail after #5174 (ping @wiredfool) abandoned the image's reported stride in favour of calculating it ourselves. This PR relaxes that slightly, by allowing the reported stride to tell us whether this is a well-formed image with an even stride, or a malformed image with an odd stride.
If the thinking is that we should just reject the malformed images, then this can be closed.