Only read different sizes for "Large Thumbnail" MPO frames #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5164
MPO images are a multi-frame format. The image from the issue reports an incorrect size for the second frame in the image.
There are different MP Types according to the spec - 'Baseline MP Primary Image', 'Large Thumbnail', 'Multi-Frame Image' and 'undefined'.
This PR resolves the issue by making it so that only 'Large Thumbnail' frames can have a different size. This isn't mentioned in the spec, but it seems possible.
This did cause one of our existing tests to fail, but that was not an image found in the wild - it was an existing test image that I hexedited. When I changed the MPType to match the image from the original issue, the test passes.