Support for ignoring tests when running valgrind #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Dec 28, 2020
Tests/conftest.py
Outdated
| warnings.simplefilter("error") | ||
| try: | ||
| getattr(pytest.mark, "valgrind_known_error") | ||
| except: |
There was a problem hiding this comment.
?
Suggested change
| except: | |
| except AttributeError: |
There was a problem hiding this comment.
I don't think it's an attribute error, as it's catching a warning thrown by pytest which hooks the getattr to specifically avoid an attribute error.
Tests/conftest.py
Outdated
| # Ensure that the mark is defined even in cases where pytest-valgrind isn't installed | ||
|
|
||
| import pytest | ||
| import warnings |
There was a problem hiding this comment.
These could go at the top of the file.
radarhere
reviewed
Dec 28, 2020
radarhere
reviewed
Dec 28, 2020
radarhere
force-pushed
the
valgrind_tests
branch
2 times, most recently
from
1dbfe2e
to
f546df4
Compare
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
wiredfool
force-pushed
the
valgrind_tests
branch
from
49c5506
to
1d7c8e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we can add valgrind as an experimental docker test target, we need to have all of the tests passing or known ignored.
This adds:
WIP -- there are more tests to investigate.