Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed OSError in favour of DecompressionBombError for BMP #4966

Merged
merged 2 commits into from Oct 12, 2020
Merged

Removed OSError in favour of DecompressionBombError for BMP #4966

merged 2 commits into from Oct 12, 2020

Conversation

radarhere
Copy link
Member

Resolves #4939

At the moment, a very large BMP file does not raise a DecompressionBombError, but instead an OSError. This PR changes it so that the more standard DecompressionBombError is raised.

@radarhere radarhere changed the title Removed OSError in favour of DecompressionBombError Removed OSError in favour of DecompressionBombError for BMP Oct 12, 2020
@radarhere radarhere mentioned this pull request Oct 12, 2020
Closed
hugovk
hugovk approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's also put this in the release notes.

@hugovk hugovk merged commit fee6baf into python-pillow:master Oct 12, 2020
@radarhere radarhere deleted the decompression branch October 12, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Making BMP pixel size limit configurable
2 participants
@radarhere @hugovk