Support raw rgba8888 for DDS #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Jul 6, 2020
|
Could you add a test that fails without this change, and passes with it? |
|
Hi, lint test has been fixed and corresponding tests are provided like dx10_bc7. |
|
@qiankanglai Hi, sorry for the late reply. What's the source for the photo of Warsaw in https://github.com/qiankanglai/Pillow/blob/dds-rgba8888/Tests/images/argb-32bpp_MipMaps-1.png?
Is it copyright or can it be released under the Pillow licence? Same questions for the other images. |
|
@hugovk Hi, I just convert the file from existing ones https://github.com/qiankanglai/Pillow/blob/dds-rgba8888/Tests/images/bc7-argb-8bpp_MipMaps-1.png (just format matters). So sorry for not knowing where it comes from but I guess it's ok for existing ones. |
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: