Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ICNS save on all operating systems #4526

Merged
merged 27 commits into from Jun 30, 2021
Merged

Allow ICNS save on all operating systems #4526

merged 27 commits into from Jun 30, 2021

Conversation

newpanjing
Copy link
Contributor

@newpanjing newpanjing commented Apr 4, 2020 •
edited by hugovk

Changes proposed in this pull request:

  • Save as icns to support all operating systems
  • Removing the restriction that you can only use macOS

@radarhere radarhere changed the title Save in icns format to support all operating systems. Save in icns format to support all operating systems Apr 4, 2020
@radarhere radarhere mentioned this pull request Apr 4, 2020
Merged
@radarhere
Copy link
Member

Thanks very much. Is there documentation that you followed when writing this?

@radarhere radarhere mentioned this pull request Apr 9, 2020
Merged
@radarhere radarhere changed the title Save in icns format to support all operating systems Allow ICNS save on all operating systems Jun 14, 2020
@nulano nulano mentioned this pull request Jun 26, 2020
Closed
hugovk
hugovk reviewed Jun 27, 2020
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions

src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
src/PIL/IcnsImagePlugin.py Outdated Show resolved Hide resolved
radarhere and others added 2 commits November 1, 2020 14:05
@radarhere @hugovk
Removed docstring sentence
63e8420 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@radarhere @hugovk
Capitalisation
d7245ea 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
radarhere and others added 3 commits December 30, 2020 12:49
@radarhere @hugovk
Updated docstring
0ff800a 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@radarhere
Merge branch 'master' into master
86ad435
@radarhere
Test ICNS on all operating systems
800a265
@BoboTiG
Copy link

BoboTiG commented Mar 2, 2021

That would be a good thing! What is the status of the PR @newpanjing ?

@hugovk hugovk merged commit 06f88dd into python-pillow:master Jun 30, 2021
@asoluter asoluter mentioned this pull request Jul 7, 2021
Closed
@radarhere radarhere mentioned this pull request Nov 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere left review comments

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@newpanjing @radarhere @BoboTiG @hugovk @baletu