Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 buffer overflows in TIFF decoding #4507

Merged
merged 5 commits into from Apr 1, 2020
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #4507 into master will decrease coverage by 0.63%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4507      +/-   ##
=========================================
- Coverage   89.83%   89.2%   -0.64%     
=========================================
  Files         328     326       -2     
  Lines       40833   40842       +9     
=========================================
- Hits        36683   36433     -250     
- Misses       4150    4409     +259
Flag Coverage Δ
#AppVeyor ?
#GHA_Docker 85.94% <40%> (-0.01%) ⬇️
#GHA_Ubuntu 87.91% <40%> (-0.13%) ⬇️
#GHA_Windows ?
#GHA_macOS 87.03% <40%> (-0.02%) ⬇️
#TravisCI 92.66% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/libImaging/TiffDecode.c 83.33% <40%> (-1.58%) ⬇️
Tests/test_imagewin_pointers.py 7.69% <0%> (-92.31%) ⬇️
Tests/test_imagewin.py 44.23% <0%> (-55.77%) ⬇️
Tests/test_locale.py 73.33% <0%> (-26.67%) ⬇️
src/PIL/ImageWin.py 35.22% <0%> (-25%) ⬇️
Tests/test_file_wmf.py 75% <0%> (-25%) ⬇️
src/PIL/WmfImagePlugin.py 74.62% <0%> (-20.9%) ⬇️
src/PIL/ImageGrab.py 75.86% <0%> (-20.69%) ⬇️
Tests/test_imagefont_bitmap.py 91.3% <0%> (-8.7%) ⬇️
src/PIL/ImageShow.py 83.33% <0%> (-7.85%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f9e19...2092801. Read the comment docs.

@hugovk
Copy link
Member Author

hugovk commented Apr 1, 2020

The 8d4fdf6 commit to "Use actions/checkout@v2 to fix checkout after restarts" isn't helping for Windows:

image

Removing from this PR, can deal with it after the release.

@hugovk
Copy link
Member Author

hugovk commented Apr 1, 2020

This is showing some older failed GHA Windows jobs, but also showing the re-runs as green. To double check, here's the same GHA jobs passing on my fork: hugovk#47.

Merging.

@hugovk hugovk merged commit 46f4a34 into python-pillow:master Apr 1, 2020
@hugovk hugovk deleted the fix_tiff branch April 1, 2020 10:33
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants