Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPEG comment to info dictionary #4455

Merged
merged 1 commit into from Mar 6, 2020

Conversation

radarhere
Copy link
Member

Resolves #4450

Adds JPEG comment to the info dictionary, in the same way that GIF and GBR do.

@radarhere radarhere added the JPEG label Feb 28, 2020
@python-pillow python-pillow deleted a comment from codecov bot Feb 28, 2020
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -298,6 +298,9 @@ The :py:meth:`~PIL.Image.Image.open` method may set the following
**exif**
Raw EXIF data from the image.

**comment**
A comment about the image.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a "New in version 7.1.0."?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Done

@hugovk
Copy link
Member

hugovk commented Mar 6, 2020

The MinGW download failures look like this:

Work has started on restoring the server, but it might take a while.

msys2/MSYS2-packages#1884 (comment)

Possible workaround here: msys2/MINGW-packages#6256 (comment), but we can probably wait a bit.

Anyway, unrelated to this PR, and it passed earlier, and only docs changes were made since if failed.

@hugovk hugovk merged commit 64c84aa into python-pillow:master Mar 6, 2020
@radarhere radarhere deleted the jpeg_comment branch March 6, 2020 20:27
@hugovk
Copy link
Member

hugovk commented Mar 9, 2020

Looks like the repo.msys2.org server is back up:
msys2/MSYS2-packages#1884

I restarted the failed job and it passed:
https://ci.appveyor.com/project/Python-pillow/pillow/build/job/i1dpyag9iv286cmj

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIL cannot read JPEG comment
2 participants