Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If present, only use alpha channel for bounding box #4454

Merged
merged 2 commits into from Mar 5, 2020

Conversation

radarhere
Copy link
Member

Resolves #4453

Changes getbbox for modes RGBA, RGBa, PA, LA and La.

Testing, I find that the current functionality is to trim black transparent pixels. This PR changes it to trim any transparent pixels, regardless of color.

@radarhere radarhere mentioned this pull request Feb 28, 2020
@python-pillow python-pillow deleted a comment from codecov bot Feb 28, 2020
@python-pillow python-pillow deleted a comment from codecov bot Mar 2, 2020
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include this change in the release notes.

@radarhere radarhere changed the title If an alpha channel is present, only use that to get bounding box If present, only use alpha channel for bounding box Mar 5, 2020
@python-pillow python-pillow deleted a comment from codecov bot Mar 5, 2020
@hugovk
Copy link
Member

hugovk commented Mar 5, 2020

Thanks for the release notes. Shall we use headings like "API Additions", "API Changes", etc?

@python-pillow python-pillow deleted a comment from codecov bot Mar 5, 2020
@hugovk hugovk merged commit 3b30b88 into python-pillow:master Mar 5, 2020
@hugovk
Copy link
Member

hugovk commented Mar 5, 2020

Thanks!

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ bug ] getbbox()
2 participants