Fix bug in TIFF loading of BufferedReader #3998

chadawagner · 2019-07-30T21:27:40Z

Fixes #3996.

Changes proposed in this pull request:

There is an existing fp value that is safely created before the call to Image._getdecoder. The same value should just be used again in the logic surrounding the actual decode.
For the case of "we have something else" (no getvalue or fileno) it should seek to the beginning as it does in other cases.

radarhere · 2019-08-02T23:56:48Z

Could you add a test that fails without your fix and passes with it?

Tests/test_file_libtiff.py

Co-Authored-By: Andrew Murray <3112309+radarhere@users.noreply.github.com>

radarhere changed the title ~~fix edge case in TIFF loading~~ Fix edge case in TIFF loading Jul 31, 2019

radarhere added TIFF Needs Tests labels Jul 31, 2019

radarhere removed the Needs Tests label Aug 3, 2019

chadawagner added 3 commits August 12, 2019 18:56

check prior fp result, do not use if False

88be36c

rewind before decode, consistent with other cases

597ca79

added test for reading TIFF from non-disk file obj

457a97d

radarhere force-pushed the master branch from 45cc293 to 457a97d Compare August 12, 2019 08:56

radarhere reviewed Aug 19, 2019

View reviewed changes

Tests/test_file_libtiff.py Outdated Show resolved Hide resolved

Update Tests/test_file_libtiff.py

34330a7

Co-Authored-By: Andrew Murray <3112309+radarhere@users.noreply.github.com>

radarhere changed the title ~~Fix edge case in TIFF loading~~ Fix bug in TIFF loading of BufferedReader Aug 22, 2019

radarhere merged commit d96f657 into python-pillow:master Aug 22, 2019

Provide feedback