Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3780 for PyPy3 as it hasn't been updated yet. #3935

Merged
merged 2 commits into from Jul 2, 2019

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Jul 2, 2019

Should fix the PyPy3 build failure introduced in 8d4bb33.

This disables the fix for #3777 for PyPy3, as PyPy's cpyext module hasn't been updated to support the new PyUnicode functions yet.

From #3835 (comment):

Our tests didn't pick it up because ... whilst we do test PyPy3 on Travis CI, there is a "implicit declaration of function ‘PyUnicode_AsUCS4Copy’" warning we didn't notice as all the test_imagefont tests are skipped because there's no FreeType (or RAQM) on PyPy3. We should improve these testing gaps.

The FreeType library was probably disabled due to a dynamic link error, not because it's not installed. FreeType works again with this PR: https://travis-ci.org/nulano/Pillow/jobs/553153042#L2976

@nulano nulano mentioned this pull request Jul 2, 2019
22 tasks
@hugovk hugovk mentioned this pull request Jul 2, 2019
@hugovk hugovk merged commit aaca672 into python-pillow:master Jul 2, 2019
@hugovk
Copy link
Member

hugovk commented Jul 2, 2019

Thanks!

@nulano nulano deleted the py_unicode-revert_pypy branch July 2, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants