Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codecov integration #3934

Closed
hugovk opened this issue Jul 2, 2019 · 7 comments
Closed

Fix Codecov integration #3934

hugovk opened this issue Jul 2, 2019 · 7 comments
Labels
Projects

Comments

@hugovk
Copy link
Member

hugovk commented Jul 2, 2019

Follow on from #3913 (comment).

Again the Codecov integration isn't reporting on PRs:

image

#3933

Ping @aclark4life. Perhaps removing and re-adding it may help?

@radarhere radarhere added this to Backlog in Pillow Jul 2, 2019
@hugovk
Copy link
Member Author

hugovk commented Jul 2, 2019

The next two PRs did report coverage (#3935, #3936) but not the third (#3937).

@hugovk
Copy link
Member Author

hugovk commented Jul 11, 2019

We're still getting some PRs with coverage reports and some PRs without.

@aclark4life
Copy link
Member

@hugovk Based on last time I looked at this, the only suggestion I can make is for the authors of all the commits to ensure they've logged into Codecov recently. And click on whatever they want you to click on (if anything). After that, we can at least rule out "developer hasn't logged into Codecov" as a possibility.

@hugovk
Copy link
Member Author

hugovk commented Jul 11, 2019

@radarhere Please can you log in to Codecov and see if anything needs clicking? Today's #3964 doesn't have coverage notifications, but it does have coverage on the site: https://codecov.io/gh/python-pillow/Pillow/commit/386002e8923ec9586d4221529963c22f01212ac4

If there's nothing out of the ordinary, let's ask at https://community.codecov.io/. Thanks!

@radarhere
Copy link
Member

I was logged in to Codecov at the time of making that PR. Checking now, the only notification that I can see is this, but I doubt it's going to the solution.

codecov

@hugovk
Copy link
Member Author

hugovk commented Jul 15, 2019

Reported to Codecov:

With a new account there I can frustratingly only post one link in the report, here's the same report with all the links:


Description

Coverage reports are being created for PRs on Codecov, but most of the time they're not showing as checks the PRs on GitHub. They used to. This makes it hard to see if the PR has tested the changed code.

https://codecov.io/gh/python-pillow/Pillow/pulls

Here's 5 recent PRs, none have Codecov checks on GitHub:

These mostly show up on the Codecov website itself with coverage:

The most recent to have a Codecov check on GitHub was 8 days ago, but there are older ones without checks:
#3956

Repository

https://github.com/python-pillow/Pillow

Versions

codecov 2.0.15 for Python

@radarhere
Copy link
Member

I think this may have resolved itself - every PR for the last three weeks has had code coverage.

@hugovk hugovk closed this as completed Oct 30, 2019
Pillow automation moved this from Backlog to Closed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Pillow
  
Closed
Development

No branches or pull requests

3 participants