Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update epsilon for FreeType 2.10 with eg. Unicode width 16 #3931

Merged
merged 1 commit into from Jul 1, 2019
Merged

Update epsilon for FreeType 2.10 with eg. Unicode width 16 #3931

merged 1 commit into from Jul 1, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 1, 2019

Potential fix for #3835 (comment):

Some new failures on pillow-wheels, TestImageFont.test_unicode_extended failed:

  • Mac MB_PYTHON_VERSION=2.7
  • Linux MB_PYTHON_VERSION=2.7 UNICODE_WIDTH=16
  • Linux MB_PYTHON_VERSION=2.7 PLAT=i686 UNICODE_WIDTH=16

With:

  • AssertionError: average pixel value difference 14.7190 > epsilon 6.2000
  • AssertionError: average pixel value difference 14.7190 > epsilon 6.2000
  • AssertionError: average pixel value difference 14.7280 > epsilon 6.2000

https://travis-ci.org/python-pillow/pillow-wheels/builds/552752918

image

@hugovk hugovk added the Fonts label Jul 1, 2019
@hugovk hugovk mentioned this pull request Jul 1, 2019
Closed
22 tasks
@hugovk hugovk merged commit 9300ced into python-pillow:master Jul 1, 2019
@hugovk hugovk deleted the update-freetype-epsilon branch July 1, 2019 15:32
@nulano nulano mentioned this pull request Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Fonts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hugovk