Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the PKG_CONFIG environment variable when building #3928

Merged
merged 1 commit into from Jul 1, 2019
Merged

Respect the PKG_CONFIG environment variable when building #3928

merged 1 commit into from Jul 1, 2019

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Jun 30, 2019

This variable is commonly used by other build systems and using it can help with cross-compiling. Falls back to pkg-config as before.

This variable is commonly used by other build systems and using it can
help with cross-compiling. Falls back to "pkg-config" as before.
@DerDakon
Copy link
Contributor

Just to clarify: this has been used in Gentoo for a while.

@aclark4life
Copy link
Member

@chewi @DerDakon LGTM, thanks. Any risk to approving this for tomorrow's release? I assume not, but if there is a risk, then we'll probably want to wait for 6.2.0… we definitely don't want to make a setup.py change and then have to release a 6.1.1 in a week 😄

@chewi
Copy link
Contributor Author

chewi commented Jun 30, 2019

It's pretty straightforward, it falls back to the old behaviour, we've had it in Gentoo a while, and your CI has (almost) passed. I think we're good. 😄

@aclark4life
Copy link
Member

@hugovk @radarhere OK if I merge this?

@hugovk
Copy link
Member

hugovk commented Jul 1, 2019

Fine by me.

Is there some documentation on the PKG_CONFIG environment variable? From a quick search I could only find PKG_CONFIG_PATH.

https://linux.die.net/man/1/pkg-config

@DerDakon
Copy link
Contributor

DerDakon commented Jul 1, 2019

The latter is how to control pkg-config, i.e. where it looks for it's stuff. The former is how a build system picks up which pkg-config or replacement executable, which is a feature of the build systems. The Linux kernel does it: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/build/feature/Makefile#n72 Others are probably doing the same. CMake has a different variable for the same purpose, but also looks ok PKG_CONFIG as a hint: https://cmake.org/cmake/help/latest/module/FindPkgConfig.html#variables-affecting-behavior

@hugovk hugovk merged commit 7585136 into python-pillow:master Jul 1, 2019
hugovk added a commit to hugovk/Pillow that referenced this pull request Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants