Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3875
When calling the ICO
load()
method, it does not just load the image the first time, but on subsequent times as well, since the size might have changed. Here is an example of the size changing, since this is not normal image behaviour -This caused the issue in question, as
load()
is called during save by_ensure_mutable()
, and that reloading is overwriting any changes that were made. The solution is to not reload the image if the size is the same.While investigating this problem, I found that it was not occurring with ICNS. Since ICO and ICNS are similar, I wanted to know what ICNS was doing differently to solve the issue. It turns out that ICNS does not support the size being changed after load like ICO does. So this PR also adds that functionality.