Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image.show() uses hardcoded path no longer valid in macOS 10.15 #3895

Closed
FlowerCode opened this issue Jun 9, 2019 · 4 comments · Fixed by #3896
Closed

Image.show() uses hardcoded path no longer valid in macOS 10.15 #3895

FlowerCode opened this issue Jun 9, 2019 · 4 comments · Fixed by #3896
Labels
Bug Any unexpected behavior, until confirmed feature. macOS
Projects
Pillow

Comments

@FlowerCode
Copy link

What did you do?

Image.show()

What did you expect to happen?

Shows image in Preview.app

What actually happened?

Crashes with invalid path for Preview.app

What are your OS, Python and Pillow versions?

  • OS: macOS 10.15
  • Python: Python 3.7.3
  • Pillow: 6.0.0

Pillow/src/PIL/ImageShow.py

Line 141 in f1ed792

'open -a /Applications/Preview.app $im;'

As part of security improvements, operating system is now separated from user data in macOS 10.15, in a read-only volume. [ref]
/Applications/Preview.app is now /System/Applications/Preview.app.
@radarhere radarhere added Awaiting OP Action Bug Any unexpected behavior, until confirmed feature. and removed Awaiting OP Action labels Jun 9, 2019
@radarhere radarhere added this to Backlog in Pillow Jun 9, 2019
@radarhere radarhere mentioned this issue Jun 9, 2019
Merged
@radarhere
Copy link
Member

Thanks for testing Pillow with beta macOS! I've created PR #3896 to address this.

@radarhere radarhere moved this from Backlog to Review/QA in Pillow Jun 9, 2019
@eirnym
Copy link

eirnym commented Jun 12, 2019

The best option compatible with all macOS systems would be: open -a Preview <params>

@hugovk
Copy link
Member

hugovk commented Jun 12, 2019

The best option compatible with all macOS systems would be: open -a Preview <params>

The PR has open -a Preview.app. Is it better to omit the .app extension?

@eirnym
Copy link

eirnym commented Jun 12, 2019

basically it's the same. .app extension will say explicitly that you opens the app.

Pillow automation moved this from Review/QA to Closed Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Any unexpected behavior, until confirmed feature. macOS
Projects
Pillow
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed Preview application path so that it is no longer static radarhere/Pillow
4 participants
@eirnym @hugovk @radarhere @FlowerCode