Tiff: Add support for JPEG quality #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
olt
force-pushed
the
tiff-jpeg-quality
branch
2 times, most recently
from
ffb0f27
to
1e91f70
Compare
|
Squashed and rebased on master (#3861). All tests pass. |
|
Rebased again. All ✅ |
- Pass tagtype from v2 directory to libtiff encoder, instead of autodetecting type. - Use explicit types. E.g. uint32_t for TIFF_LONG to fix issues on platforms with 64bit longs. - Add support for multiple values (arrays). Requires type in v2 directory and values must be passed as a tuple. - Add support for signed types (e.g. TIFFTypes.TIFF_SIGNED_SHORT).
Uses JPEGQUALITY pseudo-tag from libtiff. Also changes the way tags are passed to PyImaging_LibTiffEncoderNew from dict to list to ensure that COMPRESSION tag is added before JPEGQUALITY. This is required as the COMPRESSION tag registers the JPEGQUALITY pseudo-tag.
radarhere
force-pushed
the
tiff-jpeg-quality
branch
from
a18a371
to
2b7d8be
Compare
hugovk
approved these changes
Jun 29, 2019
There was a problem hiding this comment.
Let's also include this on Monday, if it's possible to resolve.
Please also add release notes for this and #3861 in https://github.com/python-pillow/Pillow/blob/master/docs/releasenotes/6.1.0.rst.
Thank you!
|
Merge conflict resolved. Added release notes to #3930 |
hugovk
added a commit
to hugovk/Pillow
that referenced
this pull request
Jul 1, 2019
22 tasks
|
Thank you for your patience! This'll be in 6.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow changing the image quality for JPEG compressed TIFFs.
Note: This PR depends on #3861