UnboundLocalError when opening images

[Wicloz]

What did you do?

Open an image

What did you expect to happen?

The image is opened and available for use

What actually happened?

The following error is thrown:

Traceback (most recent call last):
  File "C:/Users/wdboer/Desktop/RIP PIL/main.py", line 2, in <module>
    Image.open('broken.jpg')
  File "C:\Users\wdboer\AppData\Local\Programs\Python\Python37\lib\site-packages\PIL\Image.py", line 2690, in open
    im = _open_core(fp, filename, prefix)
  File "C:\Users\wdboer\AppData\Local\Programs\Python\Python37\lib\site-packages\PIL\Image.py", line 2676, in _open_core
    im = factory(fp, filename)
  File "C:\Users\wdboer\AppData\Local\Programs\Python\Python37\lib\site-packages\PIL\JpegImagePlugin.py", line 783, in jpeg_factory
    im = JpegImageFile(fp, filename)
  File "C:\Users\wdboer\AppData\Local\Programs\Python\Python37\lib\site-packages\PIL\ImageFile.py", line 103, in __init__
    self._open()
  File "C:\Users\wdboer\AppData\Local\Programs\Python\Python37\lib\site-packages\PIL\JpegImagePlugin.py", line 373, in _open
    handler(self, i)
  File "C:\Users\wdboer\AppData\Local\Programs\Python\Python37\lib\site-packages\PIL\JpegImagePlugin.py", line 139, in APP
    self.info["photoshop"] = photoshop
UnboundLocalError: local variable 'photoshop' referenced before assignment

What are your OS, Python and Pillow versions?

• OS: Windows 10
• Python: 3.7.2
• Pillow: 6.0.0

Please include code that reproduces the issue and whenever possible, an image that demonstrates the issue. Please upload images to GitHub, not to third-party file hosting sites. If necessary, add the image to a zip or tar archive.

The best reproductions are self-contained scripts with minimal dependencies. If you are using a framework such as plone, Django, or buildout, try to replicate the issue just using Pillow.

from PIL import Image
Image.open('broken.jpg')

[Wicloz]

I just looked at JpegImagePlugin.py and it would seem this issue has been resolved on master. The code at

Pillow/src/PIL/JpegImagePlugin.py

Line 107 in 593217f

elif marker == 0xFFED:

looks different from the other elif statements though, which might lead to other obscure issues.

[hugovk]

Thanks for the report. This has been fixed in #3769 and will be in the next release.

[radarhere]

Pillow 6.1.0 has now been released, with the fix for this.