Pass the correct types to PyArg_ParseTuple #3880
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Py_ssize_t
uses the 'n' specifier, not 'i'. IfPy_ssize_t
is bigger thanint
, this can be fine on little-endian systems but is very broken on big-endian systems as values end up 2**32 times bigger.The previous change was a bit inconsistent and only changed
src/encode.c
, but notsrc/decode.c
, so I'm not sure if I should have gone the other way and reverted theint
->Py_ssize_t
change instead.Fixes #3841.
Fixes #3840.