Improve encoding of TIFF tags #3861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the linting errors and (hopefully) the compile error on Windows. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Rebased again. All ✅ |
|
@olt Thanks for the PR and for your patience in rebasing! There's one last conflict, if you can clear that then let's merge this for Monday's release. |
hugovk
approved these changes
Jun 29, 2019
- Pass tagtype from v2 directory to libtiff encoder, instead of autodetecting type. - Use explicit types. E.g. uint32_t for TIFF_LONG to fix issues on platforms with 64bit longs. - Add support for multiple values (arrays). Requires type in v2 directory and values must be passed as a tuple. - Add support for signed types (e.g. TIFFTypes.TIFF_SIGNED_SHORT).
radarhere
reviewed
Jun 29, 2019
22 tasks
|
Thanks! Would be great to still add release notes for this one in https://github.com/python-pillow/Pillow/blob/master/docs/releasenotes/6.1.0.rst. |
hugovk
added a commit
to hugovk/Pillow
that referenced
this pull request
Jul 1, 2019
|
Release notes for this one added in #3930. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the TIFF encoder to support more types (especially arrays). This is required for the GeoTIFF format which encodes geospatial information.
autodetecting type.
platforms with 64bit longs.
directory and values must be passed as a tuple.
Note: I changed the
versionadded 3.0.0note in the docs as this has been fixed with a3d45e9 which is included in 5.4./cc @radarhere You are probably most familiar with this part.