Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apng extension to png plugin #3501

Merged
merged 6 commits into from
Dec 29, 2018
Merged

Add apng extension to png plugin #3501

merged 6 commits into from
Dec 29, 2018

Conversation

pirate486743186
Copy link
Contributor

@pirate486743186 pirate486743186 commented Dec 18, 2018

Fixes:

Some apps rely on file extensions. At least they can open apng as png now. Until apng support is actually added #3483

Changes proposed in this pull request:

  • simply add the apng extension in the png plugin.

@radarhere radarhere changed the title add apng extension to png plugin Add apng extension to png plugin Dec 18, 2018
@pirate486743186
Copy link
Contributor Author

-_-...

@hugovk
Copy link
Member

hugovk commented Dec 26, 2018

@pirate486743186 Please can you add a test .apng file and a test case?

@pirate486743186
Copy link
Contributor Author

i'm a total noob... it got more complicated then i thought it would be... I think i did what you want.

1)i added a copy of a converted iss634.webp to apng
2)i adapted a version of test_load_verify for apng
3) Merged in one commit.

@hugovk hugovk merged commit 454fdd7 into python-pillow:master Dec 29, 2018
@pirate486743186 pirate486743186 deleted the patch-2 branch December 31, 2018 06:47
@timgraham
Copy link
Contributor

I wonder if this is working correctly. After upgrading to Pillow 5.4.0 a test failure appears in Django:
https://github.com/django/django/blob/14e2b1b065085c1d2d3e94ebaeefe25e12595a00/tests/forms_tests/field_tests/test_imagefield.py#L25-L38
On the last line, the content_type has changed to image/apng. I'm not sure what differentiates png and apng but the test file is a 1x1 pixel that's not intended to be animated as far as I know.

@radarhere radarhere mentioned this pull request Jan 2, 2019
@radarhere
Copy link
Member

Thanks for finding this. I've created PR #3525 to resolve the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants