-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build Pillow 5.3.0 on Debian 9 #3462
Comments
Do the intermediate releases build? 5.0.0, 5.1.0, 5.2.0. |
Nope |
I agree with @kkopachev that it is related and that the include will help. Build seems the right tag for this issue. |
Adding INCLUDE manually is not an option, at least not a long term solution. Pillow must build out of the box on any system. Otherwise it is useless for arbitrary usage and deployments. |
Does #3245 fix it? |
@hugovk it does not fix it. It is related in the sense that both situations need to look for data in order to compile. Source data is even harder because as far as I know there isn't a specialized software artifact that hold such search paths, only standard locations. But is a little less crazy because compiled objects has much more hardware specialized data. |
Debian has a package for pillow that is kept relatively up to date in Sid. I wonder what they’ve done to it (without upstreaming changes) that gets it to build. (The last time they removed rather than fixed a bunch of pathfinding code, it wound up breaking when users installed from source on Debian. I wouldn’t be surprised if that repeated.) |
Great idea to look the Debian build system, maybe also Make and python build tools like SCons. |
Seems that SCons delegate search paths to the compiler ( Somewhat related code: https://github.com/llvm-mirror/clang/blob/5e1f58d79130478b969bcbb29dd1545852500f7f/lib/Driver/ToolChains/Linux.cpp#L41 There is a clang tool capable of dump "HeaderMap" files. https://github.com/llvm-mirror/clang/blob/e6966fe563654422468e12db1abc3aad69fd78fd/lib/Frontend/InitHeaderSearch.cpp#L210 My cheapware defected mobile phone don't let me research more. Monday I will look further. |
I had this issue on Ubuntu 18.04; It turned out that |
@hangya Thanks for sharing, it worked for me and it's a cleaner solution. |
Here's how the Pillow docker images build for Debian 9 - https://github.com/python-pillow/docker-images/blob/master/archive/debian-9-stretch-x86/Dockerfile |
Debian 9 will no longer be receiving updates - https://www.debian.org/News/2020/20200718 |
Reducing the packages used in the Debian 9 Dockerfile to build and test Pillow to those only absolutely necessary, I came up with libjpeg62-turbo-dev, python3-dev, python3-pip (for installing pytest), python3-setuptools and zlib1g-dev - see radarhere/docker-images@b095fb9 and https://github.com/radarhere/docker-images/actions/runs/1759732948. In that CI run, I was using Pillow 7.2.0, but it also works if I switch to 5.3.0. |
So yes, unable to replicate. My best guess to the original problem here is that the zlib installation was corrupted somehow. As for #3462 (comment), I wonder if that's not a different problem to being unable to find zlib. |
Debian 9 will end LTS on June 30, before the next release of Pillow. Closing, unless there are any further comments. |
We are unable to build Pillow 5.3.0 on Debian 9
Building Pillow 4.3.0 on the same system works without issue.
zlib
is of course installed:The text was updated successfully, but these errors were encountered: