From 7c48f122077671b64ff998595d9c1f3ea8ad1852 Mon Sep 17 00:00:00 2001 From: nulano Date: Fri, 26 Mar 2021 02:54:11 +0100 Subject: [PATCH] add explanatory comment for USE_WIN32_FILEIO --- setup.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/setup.py b/setup.py index 4f768d3957d..66bab7ecbe6 100755 --- a/setup.py +++ b/setup.py @@ -728,6 +728,10 @@ def build_extensions(self): libs.append(feature.tiff) defs.append(("HAVE_LIBTIFF", None)) if sys.platform == "win32": + # This define needs to be defined if-and-only-if it was defined + # when compiling LibTIFF. LibTIFF doesn't expose it in `tiffconf.h`, + # so we have to guess; by default it is defined in all Windows builds. + # See #4237, #5243, #5359 for more information. defs.append(("USE_WIN32_FILEIO", None)) if feature.xcb: libs.append(feature.xcb)