Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python_version environment marker uses wrong precision #2

Open
thatch opened this issue Sep 5, 2022 · 0 comments
Open

python_version environment marker uses wrong precision #2

thatch opened this issue Sep 5, 2022 · 0 comments

Comments

@thatch
Copy link
Member

thatch commented Sep 5, 2022

PEP 508 says that python_version is {major}.{minor} and that >= is a version-aware-comparison operator.

There are real-world examples like

python_version >= "3.5.2"

that should be interpreted as >= "3.6" but we currently do not. Maybe passing in some kind of precision to VersionIntervals.add_spec would help...

This might also help with supporting "in" for python_version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thatch