Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition plan #4

Closed
9 tasks done
krassowski opened this issue Feb 21, 2021 · 19 comments
Closed
9 tasks done

Transition plan #4

krassowski opened this issue Feb 21, 2021 · 19 comments
Milestone

Comments

@krassowski
Copy link
Contributor

krassowski commented Feb 21, 2021

Items based on @ccordoba12's palantir/python-language-server#901 (comment):

My wishlist:

@ccordoba12
Copy link
Member

rewrite the readme to markdown

Agreed.

remove Python 2 support

I think we shouldn't mix renaming the package and getting it off the ground with this task. So for now we should just make sure everything is working fine after the rename.

update copyrights notices

Agreed.

@frenzymadness
Copy link

If I might add a point: It would be nice to add Python 3.9 and 3.10 (alpha 6 currently) to the CI.

@krassowski
Copy link
Contributor Author

Note on PyPI package: python-ls is already taken (https://pypi.org/project/python-ls/) and does not seem as a good target for PEP 541 procedure (as it has some users and was active within last 2 years); it might be easier to reclaim pyls using PEP 541 (which would need to be reported here https://github.com/pypa/pypi-support/issues and seem to take a long time anyways). Probably another (temporary?) name might be needed.

@ccordoba12
Copy link
Member

Probably another (temporary?) name might be needed.

Yeah, I agree with that. What about pyls-server?

@xrogaan
Copy link

xrogaan commented Mar 5, 2021

If you have trouble finding a proper name, I would suggest yet another python-language-server, or yapls for short. (And it rolls off the tongue!) apls is sadly already taken.

@bnavigator
Copy link
Contributor

@bnavigator
Copy link
Contributor

Any news? With Python 3.9 the pressure increases to update Jedi from 0.17.2. pyls is one of the show stoppers to do so.

@ccordoba12
Copy link
Member

We will put resources to make this transition a reality most probably during April. But we can't commit to do it before that time.

@xiaoxiae
Copy link
Contributor

Other names (taken from "Python Language Server") that sound decent are PLanS and PyLaSer.

@marimeireles
Copy link
Contributor

PyLaSer is really cool.
Also, hope I can help around a bit! :)

@marimeireles
Copy link
Contributor

Note on PyPI package: python-ls is already taken (https://pypi.org/project/python-ls/) and does not seem as a good target for PEP 541 procedure (as it has some users and was active within last 2 years); it might be easier to reclaim pyls using PEP 541 (which would need to be reported here https://github.com/pypa/pypi-support/issues and seem to take a long time anyways). Probably another (temporary?) name might be needed.

Hey @krassowski :)
I didn't find an issue there, do you mind if I open one?
Also, how can I help with the pypi release? Should we complete this list first?

@ccordoba12
Copy link
Member

Hey @marimeireles, @andfoy is working on that in PR #10.

@douglasdavis
Copy link
Contributor

douglasdavis commented Apr 12, 2021

After #10 is the "official" new name for the executable pylsp? (asking to help transition https://github.com/emacs-lsp/lsp-mode/)

@ccordoba12
Copy link
Member

The name of the module, you mean?

@douglasdavis
Copy link
Contributor

I mean the entry point in setup.py:

'pylsp = pylsp.__main__:main',

@ccordoba12
Copy link
Member

Yep, that's the new name.

@andfoy
Copy link
Contributor

andfoy commented Apr 14, 2021

We have our first release officially on PyPI! https://pypi.org/project/python-lsp-server/, thanks for your help with the transition

@bnavigator
Copy link
Contributor

What's next? Migrate spyder and all the plugins?

@andfoy
Copy link
Contributor

andfoy commented Apr 14, 2021

Yes, also we need to publish new conda-forge packages, as well opening issues in all known pyls plugins to inform their maintainers that they should update to use the new package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants