Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only validate unevaluated properties/items on applicable types #949

Merged
merged 3 commits into from May 20, 2022
Merged

Only validate unevaluated properties/items on applicable types #949

merged 3 commits into from May 20, 2022

Conversation

EpicWink
Copy link
Contributor

Fixes attribute error when trying to validate unevaluatedProperties and unevaluatedItems on objects which aren't a dict or list respectively.

@Julian
Copy link
Member

Julian commented May 18, 2022

Thanks! The tests for this would actually belong first as a pull request to the official test suite. Could you perhaps give that a shot?

@Julian Julian added Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite Waiting for Author A PR waiting for author changes or issue waiting on reporter feedback labels May 18, 2022
@EpicWink
Copy link
Contributor Author

The tests for this would actually belong first as a pull request to the official test suite. Could you perhaps give that a shot?

Done, see json-schema-org/JSON-Schema-Test-Suite#550

Julian added a commit that referenced this pull request May 18, 2022
@Julian
Skip the failing unevaluated* tests until #949 is merged.
8223a95
@Julian
Copy link
Member

Julian commented May 18, 2022

Thanks! I've pulled those in here (and skipped them on master -- so you should be able to unskip them here in a commit and see these pass.)

Appreciated.

@EpicWink
Copy link
Contributor Author

@Julian that's done. Feel free to review and merge

@Julian
Copy link
Member

Julian commented May 20, 2022

Great! Thanks again

@Julian Julian merged commit d715573 into python-jsonschema:main May 20, 2022
@Julian Julian mentioned this pull request Jul 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Test Upstream Issues that need to have a test added to https://github.com/json-schema-org/JSON-Schema-Test-Suite Waiting for Author A PR waiting for author changes or issue waiting on reporter feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EpicWink @Julian