Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency pyrsistent dropped py2 support in 0.17.0 #732

Closed
wizardfishball opened this issue Sep 8, 2020 · 3 comments
Closed

Dependency pyrsistent dropped py2 support in 0.17.0 #732

wizardfishball opened this issue Sep 8, 2020 · 3 comments
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup

Comments

@wizardfishball
Copy link

Hi there! I'm not sure if jsonschema plans to keep python2 support, but just realized the dependency pyrsistent dropped python 2 support in its 0.17.0 release today.

@Julian
Copy link
Member

Julian commented Sep 8, 2020

Hi!

The next version of jsonschema will be py3-only (though will declare so appropriately via python_requires, so nothing in Py2 will break).

The same should be true of pyrsistent I hope (that it properly declares python_version, so Py2 will still work even if you haven't pinned your dependencies). If that's not the case though definitely worth bringing up there.

@Julian Julian closed this as completed Sep 8, 2020
@stas-sbi
Copy link

stas-sbi commented Sep 9, 2020

jsonschema-3.2.0 doesn't work in python2 anymore, can we have jsonschema-3.2.x with pyrsistent version restricted to <0.17.0 ?

@Julian
Copy link
Member

Julian commented Sep 9, 2020

Sounds like the pyrsistent release indeed doesn't/didn't include python_requires. It's being addressed here though: tobgu/pyrsistent#208.

That's where the fix would go so likely worth following that issue.

@Julian Julian added the Invalid Not a bug, PEBKAC, or an unsupported setup label Oct 3, 2020
Julian added a commit that referenced this issue Apr 30, 2024
54f3784a8 Merge pull request #731 from MeastroZI/main
ff29264c2 Merge pull request #741 from harrel56/chore/tabs-to-spaces
9f39cf731 use spaces instead of tabs
2f3b5f7ab Corrected replaced unevaluated with additoinalProperties
fa9224d7e Merge pull request #732 from MeastroZI/main2
83bedd5c8 Changing descriptions
49f73429c fixing tests
e6d6a0816 adding more test cases
7e6c9be6d changing descriptions
959aca926 shifting test
605d7d786 Update propertyDependencies.json : test must be tests
deb82824b test for dependentSchema and propertyDependencies with unevaluatedProperties and additionalProperties
ea4851242 Merge branch 'json-schema-org:main' into main
64a3e7b37 Merge pull request #721 from json-schema-org/gregsdennis/dynamicref-skips-resources
b9f14e64c Fix $schema in new new test
3d5048e83 Merge pull request #733 from Era-cell/main
2480edbae Update additionalProperties.json formatting it
6aa79c0b2 Update additionalProperties.json formatting it
3e0139a54 Update tests/draft-next/additionalProperties.json
616240b06 Update tests/draft-next/additionalProperties.json
c5f3e4eaa Update tests/draft2020-12/propertyNames.json
964efb8e6 propertyNames doesn't affect additionalProperties, tests exist already for unevaluatedProps
f08b884cf Cases go under additional and unevaluated Properties
99864ff66 added tests for propertyNames with additionalProperties/unevaluatedProperties, also with specification property
3b5782b65 Update ref.json : changing $Ids
546b3561a test for $ref with $recursiveAnchor
57617f254 Merge pull request #726 from Era-cell/main
51fc69cd7 meta data and property names constraints added, additional Items: string
9b169bed8 specification takes array of objects having section and quote
1362a8cce Pattern for para corrected
340116ecf Schema of specification in much structured
003ac0211 Test-schema including sub-schema for scpecification
50a20280b adding specification enhancement for additionalProperties
604f5f99b Drop tests of `$id` and `$anchor` that just test values against meta-schema `pattern` for those properties
9cd64ec94 come on man, save all the files
f494440e3 use unique $id in optional tests, too
468453b0f use unique $id
9ec6d17e7 fix copy/paste error
b284f4232 add tests for $dynamicRef skipping over resources
bf0360f4b add $recursiveAnchor to 2019-09 meta-schemas
0519d1f0e add $dynamicAnchor to meta-schemas

git-subtree-dir: json
git-subtree-split: 54f3784a8c6926d8e91ed43267950a07efc34086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup
Projects
None yet
Development

No branches or pull requests

3 participants