Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to set custom messages or use different languages #1101

Closed
gloaguen-evan opened this issue Jun 7, 2023 · 1 comment
Closed
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup

Comments

@gloaguen-evan
Copy link

Hello,

I use jsonschema to validate features and I would like to be able to modify some error messages as well as to be able to offer messages in the user's language.

This is my first participation in a project and I saw that it was better to discuss in Issues before proposing a Pull Request, so here I am.

Here is my branch:
https://github.com/gloaguen-evan/jsonschema/tree/feat(messages)/add_possibility_to_set_custom_messages_and_translation

Thank you in advance for your attention regarding my request.

Evan

@Julian
Copy link
Member

Julian commented Jun 7, 2023

Hi there! Thanks a lot for your offer, it's very much appreciated.

There's an existing issue open at #971 -- let's move discussion there if that works.

Briefly, just scanning the branch, I think we'd want to do this using the stdlib gettext module rather than rolling our own way of indicating messages. You did quite well though, especially if indeed this is your first contribution, so yeah well done! I suspect if you try wiring gettext in you may be able to mostly delete things rather than needing to make significant changes but hard to guess.

If you do do so, I will probably have limited time to review this for at least a month or two, there are a few other things on my plate that are higher priority (for the library). Don't take that as a slight I hope!

But if you're indeed interested it'd be very much appreciated, I'd love the help. Thanks again and props for the work so far.

@Julian Julian closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
@Julian Julian added the Invalid Not a bug, PEBKAC, or an unsupported setup label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Invalid Not a bug, PEBKAC, or an unsupported setup
Projects
None yet
Development

No branches or pull requests

2 participants