Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the id_of argument to validators.create and the ID_OF attribute on Validators #1091

Open
Julian opened this issue Apr 24, 2023 · 0 comments
Labels
Dialects v2 Issues which will likely be addressed as part of reworked dialect support Pending Deprecation Issues which will deprecate an existing API.

Comments

@Julian
Copy link
Member

Julian commented Apr 24, 2023

These two are redundant with the now-anyways-needed Specification objects from referencing.

Either as part of this or some time in the future there will be a way of specifying which Specification should be associated with a new Validator, but regardless, these two objects are insufficient already today for encapsulating all the information that's needed to know how to deal with schemas for a dialect.

(#1061 is somewhat tangentially related to this).

Also somewhat related is expanding support for dialect <-> vocabulary interaction. The specification is still quite immature here and may change in the future, so there's a slight worry in creating an API that matches it too closely, but this ticket may benefit from "abandoning" jsonschema.validators.* in favor of new APIs that create dialects...

@Julian Julian added the Pending Deprecation Issues which will deprecate an existing API. label Apr 24, 2023
@Julian Julian added the Dialects v2 Issues which will likely be addressed as part of reworked dialect support label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dialects v2 Issues which will likely be addressed as part of reworked dialect support Pending Deprecation Issues which will deprecate an existing API.
Projects
None yet
Development

No branches or pull requests

1 participant