RemoteProtocolError event_hint parameter

[Kludex]

Hi 👋

I was trying to add a test on uvicorn, when conn.receive_data() was able to send a RemoteProtocolError without an error hint:

https://github.com/encode/uvicorn/blob/22bd00eab6dfa7145618ce6cd1acfdffea8bbe6e/uvicorn/protocols/websockets/wsproto_impl.py#L89-L94

But the thing is... In the whole wsproto source code, there's always an event_hint being sent.

Can we make event_hint mandatory here?

wsproto/src/wsproto/utilities.py

Line 50 in a7d9ff0

def __init__(self, message: str, event_hint: Optional[Event] = None) -> None:

EDIT: See encode/uvicorn#1486.

[Kludex]

👋

[Kludex]

👋

[njsmith]

Seems fine to me.

…

On Sun, Dec 17, 2023, 00:59 Marcelo Trylesinski ***@***.***> wrote: 👋 — Reply to this email directly, view it on GitHub <#178 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEU42DRJZCFBAAPQR5HTFTYJ2YARAVCNFSM6AAAAAARR526MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGA3TQMZYGI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[Kludex]

Why?