Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI status. #75

Merged
merged 2 commits into from May 6, 2021
Merged

Conversation

tomchristie
Copy link
Contributor

@tomchristie tomchristie commented May 6, 2021

Prompted by the latest test run for this repo having failed, due to black linting... https://travis-ci.org/github/python-hyper/rfc3986/builds/746799781

Also pins attrs to 20.1.0 in the dev-requirements.txt, since that's the last version to offer Python 3.4 support.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #75 (8b5f2f3) into master (dba3ada) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #75   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          822       822           
=========================================
  Hits           822       822           
Impacted Files Coverage Δ
src/rfc3986/_mixin.py 100.00% <ø> (ø)
src/rfc3986/builder.py 100.00% <ø> (ø)
src/rfc3986/exceptions.py 100.00% <ø> (ø)
src/rfc3986/validators.py 100.00% <ø> (ø)
src/rfc3986/abnf_regexp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba3ada...8b5f2f3. Read the comment docs.

@tomchristie
Copy link
Contributor Author

Bigger question here is what can I be doing to help wrt. maintenance on rfc3986?

We've got a bug outstanding on encode/httpx#1517 that's resolved in rfc3986 master, but not yet on PyPI.

I'd be happy to step up to maintenance tasks here & on PyPI if needed, or else help out in a contributor role. Whichever works best for you folks?

@tomchristie tomchristie changed the title Black formatting Fix CI status. May 6, 2021
@sigmavirus24 sigmavirus24 merged commit 37cf287 into master May 6, 2021
@sigmavirus24 sigmavirus24 deleted the format-against-latest-version-of-black branch May 6, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants