Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a new version of Connection that returns/accepts enum types for PAUSED/NEED_DATA our_role their_role etc #153

Open
graingert opened this issue Jun 19, 2022 · 1 comment · May be fixed by #154
Open

provide a new version of Connection that returns/accepts enum types for PAUSED/NEED_DATA our_role their_role etc #153

graingert opened this issue Jun 19, 2022 · 1 comment · May be fixed by #154

Comments

@graingert
Copy link

the current Connection.next_event Event | type[_Sentinel] return type is slightly painful to work with. It would be useful to have a version that returns enum based sentinels instead
@graingert graingert changed the title provide a new version of Connection that returns/accepts enum types for PAUSED/NEED_DATA provide a new version of Connection that returns/accepts enum types for PAUSED/NEED_DATA our_role their_role etc Jun 19, 2022
@graingert
Copy link
Author

graingert commented Jun 19, 2022 •
edited

see also #144 and https://discuss.python.org/t/pep-661-sentinel-values/9126/1

@pgjones pgjones linked a pull request Aug 25, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from Sentinel types to Enums pgjones/h11
1 participant
@graingert