Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "ValueError: math domain error" for metric(0) #47

Merged
merged 1 commit into from Aug 8, 2022

Conversation

liukun
Copy link
Contributor

@liukun liukun commented Aug 8, 2022

Call metrics(0) gives ValueError: math domain error before this patch.

Call metrics(0) gives `ValueError: math domain error` before this patch.
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #47 (b1ee687) into main (dab62bf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files           9        9           
  Lines         690      690           
=======================================
  Hits          684      684           
  Misses          6        6           
Flag Coverage Δ
macos-latest 97.39% <100.00%> (ø)
ubuntu-latest 97.39% <100.00%> (ø)
windows-latest 97.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_number.py 100.00% <ø> (ø)
src/humanize/number.py 96.99% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hugovk hugovk added the changelog: Fixed For any bug fixes label Aug 8, 2022
@hugovk hugovk changed the title Fix metric(0) crash. Fix "ValueError: math domain error" for metric(0) Aug 8, 2022
@hugovk hugovk merged commit 14fc392 into python-humanize:main Aug 8, 2022
@hugovk
Copy link
Member

hugovk commented Aug 8, 2022

Thanks!

@hugovk hugovk changed the title Fix "ValueError: math domain error" for metric(0) Fix "ValueError: math domain error" for metric(0) Sep 1, 2022
@bersbersbers bersbersbers mentioned this pull request Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants